change the name of struct blockIODevice to BlockIODevice#232
Closed
wangkirin wants to merge 1 commit intoopencontainers:masterfrom
Closed
change the name of struct blockIODevice to BlockIODevice#232wangkirin wants to merge 1 commit intoopencontainers:masterfrom
blockIODevice to BlockIODevice#232wangkirin wants to merge 1 commit intoopencontainers:masterfrom
Conversation
Signed-off-by: Wang Qilin <wangqilin2@huawei.com>
Member
|
IIRC I did this way so the inner struct was hidden and you just had to instantiate the upper struct with only the public fields (I explicitly did this way cause I didn't want another struct just for Major, Minor and you can always use the other struct without instantiating the private one). This is to say that unless something really needs it I think exporting this structure is meaningless |
Member
|
This is intentional. It'll stay not exported for now. |
Contributor
|
On Sun, Oct 25, 2015 at 08:06:35AM -0700, Antonio Murdaca wrote:
This got unpacked in more detail on IRC today, starting with 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the struct
blockIODeviceis begin with lower case letters, and we cannot export it and instantiate it from other packages.This PR fixed itSigned-off-by: Wang Qilin wangqilin2@huawei.com